refactor(tron-wallet-snap): organize handlers and rename asset reader functions - #90
Open
ulissesferreira wants to merge 4 commits into
Open
refactor(tron-wallet-snap): organize handlers and rename asset reader functions#90ulissesferreira wants to merge 4 commits into
ulissesferreira wants to merge 4 commits into
Conversation
Pure organizational move with import path updates only. No AssetsService API renames or behavior changes.
Align public reader names with the final AssetsController-oriented API: getAccountAssets, getAccountAssetsByIDs, getAccountAssetByID.
Handler folder move requires importing from ../cronjob/cronjob rather than the bare folder path so the Snap bundle resolves correctly.
2 tasks
ulissesferreira
temporarily deployed
to
default-branch
July 31, 2026 21:38 — with
GitHub Actions
Inactive
Handler files moved into subfolders in WPN-1497, so point eslint suppressions at the new paths and refresh snap.manifest.json after the handler import path fix changed the bundle hash.
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handlers/assets/,cronjob/,keyring/,user-input/) with explicit import pathsAssetsServiceaccount readers:getAccountAssets,getAccountAssetsByIDs,getAccountAssetByIDJira
Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run testPart of the AssetsController migration split stack (Step 1/3).